Re: [PATCH v6 4/7] arm64: dts: qcom: ipq5332: Add tsens node

[Manikanta Mylavarapu]

On 11/7/2024 8:20 PM, Konrad Dybcio wrote:
> On 4.11.2024 1:44 PM, Manikanta Mylavarapu wrote:
>> From: Praveenkumar I <quic_ipkumar@xxxxxxxxxxx>
>>
>> IPQ5332 has tsens v2.3.3 peripheral. This patch adds the tsense
>> node with nvmem cells for calibration data.
>>
>> Signed-off-by: Praveenkumar I <quic_ipkumar@xxxxxxxxxxx>
>> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@xxxxxxxxxxx>
>> ---
>> Changes in V6:
>> 	- No change
>>
>>  arch/arm64/boot/dts/qcom/ipq5332.dtsi | 66 +++++++++++++++++++++++++++
>>  1 file changed, 66 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
>> index d3c3e215a15c..94dca05fdc2a 100644
>> --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
>> @@ -177,6 +177,46 @@ cpu_speed_bin: cpu-speed-bin@1d {
>>  				reg = <0x1d 0x2>;
>>  				bits = <7 2>;
>>  			};
>> +
>> +			s11: s11@3a5 {
> 
> You're adding 's11' etc. to the global label namespace. Please make
> the names more specific, like tsens_sens11_off
> 
> [...]
> 

Okay, sure. I will update.

>> +		tsens: thermal-sensor@4a9000 {
>> +			compatible = "qcom,ipq5332-tsens";
>> +			reg = <0x4a9000 0x1000>,
>> +			      <0x4a8000 0x1000>;
> 
> Please pad the address part to 8 hex digits with leading zeroes.
> 

Leading zeros are already padded in V7 series.

Thanks & Regards,
Manikanta.