Re: [PATCH] tools/memory-model: Fix litmus-tests's file names for case-insensitive filesystem.
From: Paul E. McKenney
Date: Mon Nov 11 2024 - 11:54:40 EST
On Mon, Nov 11, 2024 at 05:42:47PM +0100, egyszeregy@xxxxxxxxxxx wrote:
> From: Benjamin Szőke <egyszeregy@xxxxxxxxxxx>
>
> The goal is to fix Linux repository for case-insensitive filesystem,
> to able to clone it and editable on any operating systems.
>
> Rename "Z6.0+pooncelock+poonceLock+pombonce.litmus" to
> "Z6.0+pooncelock+poonceLock+after_spinlock+pombonce.litmus".
>
> Signed-off-by: Benjamin Szőke <egyszeregy@xxxxxxxxxxx>
Ummm... Really?
Just out of curiosity, which operating-system/filesystem combination are
you working with? And why not instead fix that combination to handle
mixed case?
Thanx, Paul
> ---
> tools/memory-model/Documentation/locking.txt | 2 +-
> tools/memory-model/Documentation/recipes.txt | 2 +-
> tools/memory-model/litmus-tests/README | 2 +-
> ...> Z6.0+pooncelock+poonceLock+after_spinlock+pombonce.litmus} | 0
> 4 files changed, 3 insertions(+), 3 deletions(-)
> rename tools/memory-model/litmus-tests/{Z6.0+pooncelock+poonceLock+pombonce.litmus => Z6.0+pooncelock+poonceLock+after_spinlock+pombonce.litmus} (100%)
>
> diff --git a/tools/memory-model/Documentation/locking.txt b/tools/memory-model/Documentation/locking.txt
> index 65c898c64a93..42bc3efe2015 100644
> --- a/tools/memory-model/Documentation/locking.txt
> +++ b/tools/memory-model/Documentation/locking.txt
> @@ -184,7 +184,7 @@ ordering properties.
> Ordering can be extended to CPUs not holding the lock by careful use
> of smp_mb__after_spinlock():
>
> - /* See Z6.0+pooncelock+poonceLock+pombonce.litmus. */
> + /* See Z6.0+pooncelock+poonceLock+after_spinlock+pombonce.litmus. */
> void CPU0(void)
> {
> spin_lock(&mylock);
> diff --git a/tools/memory-model/Documentation/recipes.txt b/tools/memory-model/Documentation/recipes.txt
> index 03f58b11c252..35996eb1b690 100644
> --- a/tools/memory-model/Documentation/recipes.txt
> +++ b/tools/memory-model/Documentation/recipes.txt
> @@ -159,7 +159,7 @@ lock's ordering properties.
> Ordering can be extended to CPUs not holding the lock by careful use
> of smp_mb__after_spinlock():
>
> - /* See Z6.0+pooncelock+poonceLock+pombonce.litmus. */
> + /* See Z6.0+pooncelock+poonceLock+after_spinlock+pombonce.litmus. */
> void CPU0(void)
> {
> spin_lock(&mylock);
> diff --git a/tools/memory-model/litmus-tests/README b/tools/memory-model/litmus-tests/README
> index d311a0ff1ae6..e3d451346400 100644
> --- a/tools/memory-model/litmus-tests/README
> +++ b/tools/memory-model/litmus-tests/README
> @@ -149,7 +149,7 @@ Z6.0+pooncelock+pooncelock+pombonce.litmus
> spin_lock() sufficient to make ordering apparent to accesses
> by a process not holding the lock?
>
> -Z6.0+pooncelock+poonceLock+pombonce.litmus
> +Z6.0+pooncelock+poonceLock+after_spinlock+pombonce.litmus
> As above, but with smp_mb__after_spinlock() immediately
> following the spin_lock().
>
> diff --git a/tools/memory-model/litmus-tests/Z6.0+pooncelock+poonceLock+pombonce.litmus b/tools/memory-model/litmus-tests/Z6.0+pooncelock+poonceLock+after_spinlock+pombonce.litmus
> similarity index 100%
> rename from tools/memory-model/litmus-tests/Z6.0+pooncelock+poonceLock+pombonce.litmus
> rename to tools/memory-model/litmus-tests/Z6.0+pooncelock+poonceLock+after_spinlock+pombonce.litmus
> --
> 2.47.0.windows.2
>