Re: [PATCH v4 1/2] dt-bindings: input: Goodix GT7986U SPI HID Touchscreen

From: Doug Anderson
Date: Mon Nov 11 2024 - 12:26:04 EST


Hi,

On Sun, Nov 10, 2024 at 11:50 PM Charles Wang <charles.goodix@xxxxxxxxx> wrote:
>
> The Goodix GT7986U touch controller report touch data according to the
> HID protocol through the SPI bus. However, it is incompatible with
> Microsoft's HID-over-SPI protocol.
>
> NOTE: these bindings are distinct from the bindings used with the
> GT7986U when the chip is running I2C firmware. For some background,
> see discussion on the mailing lists in the thread:
>
> https://lore.kernel.org/r/20241018020815.3098263-2-charles.goodix@xxxxxxxxx
>
> Signed-off-by: Charles Wang <charles.goodix@xxxxxxxxx>
> ---
> .../bindings/input/goodix,gt7986u-spifw.yaml | 69 +++++++++++++++++++
> 1 file changed, 69 insertions(+)

As far as I can tell this looks fine now. Thanks!

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>