Re: [PATCH V3 net-next 5/7] net: hibmcge: Add pauseparam supported in this module
From: Andrew Lunn
Date: Mon Nov 11 2024 - 13:13:52 EST
On Mon, Nov 11, 2024 at 10:55:56PM +0800, Jijie Shao wrote:
> The MAC can automatically send or respond to pause frames.
> This patch supports the function of enabling pause frames
> by using ethtool.
>
> Pause auto-negotiation is not supported currently.
What is actually missing to support auto-neg pause? You are using
phylib, so it will do most of the work. You just need your adjust_link
callback to configure the hardware to the result of the negotiation.
And call phy_support_asym_pause() to let phylib know what the MAC
supports.
Andrew