Re: [PATCH net-next v4] eth: fbnic: Add PCIe hardware statistics

[Sanman Pradhan]

On Fri, 8 Nov 2024 at 19:57, Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> On Fri,  8 Nov 2024 18:59:05 -0800 Sanman Pradhan wrote:
> > v4:
> >       - Fix indentations
> >       - Adding missing updates for previous versions
>
> Please don't post multiple versions a day, per:
> https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#tl-dr
>
> >  .../device_drivers/ethernet/meta/fbnic.rst    |  26 ++++
> >  drivers/net/ethernet/meta/fbnic/fbnic_csr.h   |  37 ++++++
> >  .../net/ethernet/meta/fbnic/fbnic_debugfs.c   |  54 +++++++++
> >  .../net/ethernet/meta/fbnic/fbnic_hw_stats.c  | 114 ++++++++++++++++++
> >  .../net/ethernet/meta/fbnic/fbnic_hw_stats.h  |  12 ++
> >  .../net/ethernet/meta/fbnic/fbnic_netdev.c    |   3 +
> >  6 files changed, 246 insertions(+)
> >  create mode 100644 drivers/net/ethernet/meta/fbnic/fbnic_debugfs.c
>
> I just realized that you couldn't have tested this patch properly
> because you added a file, did not include it in the Makefile, and
> yet the build doesn't break. So you must be calling neither
> fbnic_dbg_init() nor fbnic_dbg_exit().
>
> Not great.
> --
Thank you for the review.
Sorry for posting multiple patches under 24 hours and for the
oversight on fbnic_dbg_init() nor fbnic_dbg_exit().
Have submitted v5 with the expected changes and test logs
> pw-bot: cr