Re: [RFC PATCH v2 1/3] x86: cpu/bugs: update SpectreRSB comments for AMD
From: Josh Poimboeuf
Date: Mon Nov 11 2024 - 15:41:07 EST
On Mon, Nov 11, 2024 at 12:39:09PM -0800, Josh Poimboeuf wrote:
> This is why it's important to spell out all the different cases in the
> comments. I was attempting to document the justifications for the
> existing behavior.
>
> You make some good points, though backing up a bit, I realize my comment
> was flawed for another reason: the return thunks only protect the
> kernel, but RSB filling on context switch is meant to protect user
> space.
>
> So, never mind...
That said, I still think the comments need an update. I'll try to come
up with something later.
--
Josh