Aw: Re: [PATCH] dt-bindings: spi: add compatibles for mt7988
From: Frank Wunderlich
Date: Mon Nov 11 2024 - 17:25:06 EST
> Gesendet: Montag, 11. November 2024 um 21:38
> Von: "Rob Herring" <robh@xxxxxxxxxx>
> An: "Frank Wunderlich" <linux@xxxxxxxxx>
> CC: "Mark Brown" <broonie@xxxxxxxxxx>, "Krzysztof Kozlowski" <krzk+dt@xxxxxxxxxx>, "Conor Dooley" <conor+dt@xxxxxxxxxx>, "Matthias Brugger" <matthias.bgg@xxxxxxxxx>, "AngeloGioacchino Del Regno" <angelogioacchino.delregno@xxxxxxxxxxxxx>, "Frank Wunderlich" <frank-w@xxxxxxxxxxxxxxx>, "Leilk Liu" <leilk.liu@xxxxxxxxxxxx>, linux-spi@xxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-mediatek@xxxxxxxxxxxxxxxxxxx
> Betreff: Re: [PATCH] dt-bindings: spi: add compatibles for mt7988
>
> On Sat, Nov 09, 2024 at 11:50:28AM +0100, Frank Wunderlich wrote:
> > From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
> >
> > MT7988 has 2 different spi controllers. Add their compatibles.
> >
> > Signed-off-by: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
> > ---
> > Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> > index e1f5bfa4433c..ed17815263a8 100644
> > --- a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> > +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> > @@ -35,6 +35,8 @@ properties:
> > - enum:
> > - mediatek,mt7981-spi-ipm
> > - mediatek,mt7986-spi-ipm
> > + - mediatek,mt7988-spi-quad
> > + - mediatek,mt7988-spi-single
> > - mediatek,mt8188-spi-ipm
> > - const: mediatek,spi-ipm
>
> Does the fallback make sense for both? Is there some common subset of
> functionality where they are the same?
currently they work only with the fallback compatible, but we see in SDK that there are 2 types...in SDK non-soc specific compatibles are used which was rejected last time.
> Rob
> </frank-w@xxxxxxxxxxxxxxx></frank-w@xxxxxxxxxxxxxxx></leilk.liu@xxxxxxxxxxxx></frank-w@xxxxxxxxxxxxxxx></angelogioacchino.delregno@xxxxxxxxxxxxx></matthias.bgg@xxxxxxxxx></conor+dt@xxxxxxxxxx></krzk+dt@xxxxxxxxxx></broonie@xxxxxxxxxx></linux@xxxxxxxxx></robh@xxxxxxxxxx>