Re: [PATCH v1 3/5] ARM: dts: aspeed: Harma: Revise GPIO line name

[Andrew Jeffery]

Hi Peter,

On Mon, 2024-11-11 at 17:43 +0800, Peter Yin wrote:
>   Add:
>     "ac-power-button",
>     "asic0-card-type-detection0-n"
>     "asic0-card-type-detection1-n"
>     "asic0-card-type-detection2-n"
> 
>     "cpu0-prochot-alert",
>     "cpu0-thermtrip-alert",
> 
>     "irq-uv-detect-alert",
>     "irq-hsc-alert",
> 
>     "uart-switch-button"
>     "uart-switch-lsb"
>     "uart-switch-msb"
> 
>     "leakage-detect-alert",
> 
>     "power-card-enable",
>     "power-fault-n",
>     "power-hsc-good",
>     "power-chassis-good"
>     "presence-post-card",
>     "presence-cmm"
>     "pvdd11-ocp-alert"
> 
>     "reset-control-cmos-clear"
>     "reset-cause-pcie",
>     "reset-cause-platrst",
> 
>     "P0_I3C_APML_ALERT_L",

Rather than list the identifiers that are already contained in the
patch, can you please discuss what functionality these identifiers
enable, how different functions are related, and why this must all be
done in one patch?

> 
>   Rename:
>     "power-cpu-good" to "host0-ready",
>     "host-ready-n" to "post-end-n

On the other-hand, explicitly calling out these changes is helpful, but
please also discuss the motivation and impact.

Andrew