Re: [PATCH v4 6/6] rust: add improved version of `ForeignOwnable::borrow_mut`

From: Miguel Ojeda
Date: Mon Nov 11 2024 - 19:03:42 EST


On Mon, Nov 11, 2024 at 5:22 PM Tamir Duberstein <tamird@xxxxxxxxx> wrote:
>
> My reading of that discussion is that the new `crate::ffi` module
> isn't going anywhere, it's just the later patches that diverge the
> types that might be dropped for now and taken later.

Yeah, that was my plan, and I ended up with that.

However, we still need to see how it actually goes -- we will see tomorrow.

> In my case though I have a hard conflict as the patch introducing
> `crate::ffi` and this series touch the same lines so I think a rebase
> is unavoidable.

If there are conflicts, then a new version is usually welcome, unless
the conflict is small or trivial (i.e. sometimes maintainers may do
the rebase for you and other adjustments -- a new version may not be
worth it, and it depends on the maintainer).

In this case, please wait a few days to see if you get more feedback,
and meanwhile the linux-next issue will be resolved one way or
another, so you can use whatever is in rust-next by then.

Thanks!

Cheers,
Miguel