Re: [PATCH net-next v3 4/9] net: stmmac: Introduce dwmac1000 ptp_clock_info and operations

From: Jakub Kicinski
Date: Mon Nov 11 2024 - 19:12:16 EST


On Wed, 6 Nov 2024 10:03:25 +0100 Maxime Chevallier wrote:
> + mutex_unlock(&priv->aux_ts_lock);
> +
> + /* wait for auxts fifo clear to finish */
> + ret = readl_poll_timeout(ptpaddr + PTP_TCR, tcr_val,
> + !(tcr_val & GMAC_PTP_TCR_ATSFC),
> + 10, 10000);

Is there a good reason to wait for the flush to complete outside of
the mutex?