Re: [PATCH] arm64: kvm: Make nvhe stack size configurable
From: Kalesh Singh
Date: Mon Nov 11 2024 - 19:54:02 EST
On Mon, Nov 11, 2024 at 9:52 AM Marc Zyngier <maz@xxxxxxxxxx> wrote:
>
> Hi Kalesh,
>
> On Mon, 11 Nov 2024 17:10:18 +0000,
> Kalesh Singh <kaleshsingh@xxxxxxxxxx> wrote:
> >
> > I tried to be conservative with the configuration only allowing only
> > up to 2 pages. Your points are fair concerns, I can see how this still
> > may not be ideal for upstream. However, I think introducing
> > NVHE_STACK_SIZE as a refactor still has value, similar to how
> > OVERFLOW_STACK_SIZE is handled. If there are no objections, I’ll
> > resend a v2 of the patch, dropping the configuration parts and
> > focusing on the refactor to introduce NVHE_STACK_SIZE.
>
> I'd be OK with the refactoring on its own, which is a nice enough
> cleanup.
Posted v2 at: https://lore.kernel.org/r/20241112003336.1375584-1-kaleshsingh@xxxxxxxxxx/
Thanks,
Kalesh
>
> Thanks,
>
> M.
>
> --
> Without deviation from the norm, progress is not possible.