Re: [PATCH 1/2] docs: net: Fix text in eth/intel, mlx5 and switchdev docs

From: Jakub Kicinski
Date: Mon Nov 11 2024 - 22:04:12 EST


On Fri, 8 Nov 2024 13:25:47 -0700 Abhinav Saxena wrote:
> diff --git a/Documentation/networking/switchdev.rst b/Documentation/networking/switchdev.rst
> index f355f0166f1b..df4b4c4a15d5 100644
> --- a/Documentation/networking/switchdev.rst
> +++ b/Documentation/networking/switchdev.rst
> @@ -162,7 +162,7 @@ The switchdev driver can know a particular port's position in the topology by
> monitoring NETDEV_CHANGEUPPER notifications. For example, a port moved into a
> bond will see its upper master change. If that bond is moved into a bridge,
> the bond's upper master will change. And so on. The driver will track such
> -movements to know what position a port is in in the overall topology by
> +movements to know what position a port is in the overall topology by

Are you sure? The first 'in' is for position, the second for topology.
Equivalent to:

movements to know in what position a port is in the overall topology by
^^ ^^

We can rephrase to avoid the double in:

The driver will track such movements to know the position of a port
within the overall topology by registering for netdevice events and
acting on NETDEV_CHANGEUPPER.

> registering for netdevice events and acting on NETDEV_CHANGEUPPER.
--
pw-bot: cr