Re: [PATCHv2 net-next] net: modernize ioremap in probe

[Marc Kleine-Budde]

On 11.11.2024 12:02:12, Rosen Penev wrote:
> I changed resource acquisition to be performed in a single step. Possible
> because devm is used here.

You should describe in an imperative way your changes. Something like:

Resource acquisition can be performed in a single step.

Replace platform_get_resource_byname() + devm_ioremap() by
devm_platform_ioremap_resource_byname().

...and list the other changes, too.

> Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
> ---
>  v2: fixed compilation errors on PPC and reworded commit message
>  drivers/net/can/m_can/m_can_platform.c        | 13 +++-------
>  drivers/net/can/sja1000/sja1000_platform.c    | 15 +++--------

Reviewed-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> # for CAN

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Attachment: signature.asc
Description: PGP signature