Re: [PATCH 1/1] arm64: dts: marvell: mcbin: fix PCIe reset property

[Russell King (Oracle)]

On Mon, Nov 11, 2024 at 11:20:49PM -0800, Jenishkumar Maheshbhai Patel wrote:
> Set reset gpio to active high
> 
> Fixes: b83e1669adce ("arm64: dts: marvell: mcbin: add support for PCIe")
> 
> Signed-off-by: Jenishkumar Maheshbhai Patel <jpatel2@xxxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi
> index c864df9ec84d..a8c732a47360 100644
> --- a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi
> @@ -181,7 +181,7 @@ &cp0_pcie0 {
>  	pinctrl-0 = <&cp0_pcie_pins>;
>  	num-lanes = <4>;
>  	num-viewport = <8>;
> -	reset-gpios = <&cp0_gpio2 20 GPIO_ACTIVE_LOW>;
> +	reset-gpios = <&cp0_gpio2 20 GPIO_ACTIVE_HIGH>;

Is this change due to switching the driver to use the reset controller?
If so, NAK to all the changes - DT files are meant to be forwards
compatible (older DT are supposed to work with newer kernels) and it
would seem this would break that rule.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!