Re: [PATCH v2] firewall: remove misplaced semicolon from stm32_firewall_get_firewall

From: Gatien CHEVALLIER
Date: Tue Nov 12 2024 - 04:55:14 EST


On 11/12/24 10:25, Alexandre TORGUE wrote:
Hi

On 11/9/24 06:50, guanjing wrote:
Remove misplaced colon in stm32_firewall_get_firewall()
which results in a syntax error when the code is compiled
without CONFIG_STM32_FIREWALL.

Fixes: 5c9668cfc6d7 ("firewall: introduce stm32_firewall framework")
Signed-off-by: guanjing <guanjing@xxxxxxxxxxxxxxxxxxxx>
---
  include/linux/bus/stm32_firewall_device.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/bus/stm32_firewall_device.h b/include/linux/bus/stm32_firewall_device.h
index 18e0a2fc3816..5178b72bc920 100644
--- a/include/linux/bus/stm32_firewall_device.h
+++ b/include/linux/bus/stm32_firewall_device.h
@@ -115,7 +115,7 @@ void stm32_firewall_release_access_by_id(struct stm32_firewall *firewall, u32 su
  #else /* CONFIG_STM32_FIREWALL */
  int stm32_firewall_get_firewall(struct device_node *np, struct stm32_firewall *firewall,
-                unsigned int nb_firewall);
+                unsigned int nb_firewall)
  {
      return -ENODEV;
  }

Acked-by: Alexandre Torgue <alexandre.torgue@xxxxxxxxxxx>

Thanks
Alex

Hi, please use get_maintainers.pl script next time so that
adequate people are put in To/CC.
Nevertheless, thanks for the patch!

Reviewed-by: Gatien Chevallier <gatien.chevallier@xxxxxxxxxxx>