Re: [PATCH][next] mm: shmem: Fix error checking on utf8_parse_version failures

[Colin King (gmail)]

On 12/11/2024 10:06, André Almeida wrote:
> Hi Colin,
>
> Em 12/11/2024 06:54, Colin Ian King escreveu:
> > Currently the error check on the call to utf8_parse_version is always
> > false because version is an unsigned int and this can never be less
> > than zero. Because version is required to be an unsigned int, fix the
> > issue by casting it to int just for the error check.
>
> Why is it required to be an unsigned int?

It's being passed to various functions that expect unsigned int, so I 
presume it was intended to be of that type.

Colin

> > Fixes: 58e55efd6c72 ("tmpfs: Add casefold lookup support")
> > Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>
>
> Another fix was already sent: https://lore.kernel.org/lkml/20241111- 
> unsignedcompare1601569-v1-1-c4a9c3c75a52@xxxxxxxxx/