Re: [PATCH v5 15/28] media: iris: implement query_cap ioctl

From: Hans Verkuil
Date: Tue Nov 12 2024 - 05:26:08 EST


On 05/11/2024 07:55, Dikshita Agarwal wrote:
> From: Vedang Nagar <quic_vnagar@xxxxxxxxxxx>
>
> Implement query_cap ioctl with necessary hooks.
>
> Signed-off-by: Vedang Nagar <quic_vnagar@xxxxxxxxxxx>
> Signed-off-by: Dikshita Agarwal <quic_dikshita@xxxxxxxxxxx>
> ---
> drivers/media/platform/qcom/iris/iris_vidc.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/media/platform/qcom/iris/iris_vidc.c b/drivers/media/platform/qcom/iris/iris_vidc.c
> index 820d98da3190..e270711b8f6b 100644
> --- a/drivers/media/platform/qcom/iris/iris_vidc.c
> +++ b/drivers/media/platform/qcom/iris/iris_vidc.c
> @@ -303,6 +303,14 @@ static int iris_enum_framesizes(struct file *filp, void *fh,
> return 0;
> }
>
> +static int iris_querycap(struct file *filp, void *fh, struct v4l2_capability *cap)
> +{
> + strscpy(cap->driver, IRIS_DRV_NAME, sizeof(cap->driver));
> + strscpy(cap->card, "iris_decoder", sizeof(cap->card));

The card field is supposed to be a human readable strings, so I
would suggest using "Iris Decoder" instead. Up to you, though.

Regards,

Hans

> +
> + return 0;
> +}
> +
> static int iris_g_selection(struct file *filp, void *fh, struct v4l2_selection *s)
> {
> struct iris_inst *inst = iris_get_inst(filp, NULL);
> @@ -361,6 +369,7 @@ static const struct v4l2_ioctl_ops iris_v4l2_ioctl_ops = {
> .vidioc_g_fmt_vid_out_mplane = iris_g_fmt_vid_mplane,
> .vidioc_enum_framesizes = iris_enum_framesizes,
> .vidioc_reqbufs = v4l2_m2m_ioctl_reqbufs,
> + .vidioc_querycap = iris_querycap,
> .vidioc_g_selection = iris_g_selection,
> .vidioc_subscribe_event = iris_subscribe_event,
> .vidioc_unsubscribe_event = v4l2_event_unsubscribe,
>