Re: [PATCH v4 0/3] fs: allow statmount to fetch the fs_subtype and sb_source

From: Jeff Layton
Date: Tue Nov 12 2024 - 06:28:09 EST


On Tue, 2024-11-12 at 11:32 +0100, Miklos Szeredi wrote:
> On Mon, 11 Nov 2024 at 16:10, Jeff Layton <jlayton@xxxxxxxxxx> wrote:
> >
> > Meta has some internal logging that scrapes /proc/self/mountinfo today.
> > I'd like to convert it to use listmount()/statmount(), so we can do a
> > better job of monitoring with containers. We're missing some fields
> > though. This patchset adds them.
> >
> > Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>
>
> When thinking of the naming for the unescaped options, I realized that
> maybe "source" is better than "sb_soure" which just adds redundant
> info. Just a thought, don't bother if you don't agree.
>
> Acked-by: Miklos Szeredi <mszeredi@xxxxxxxxxx>
>

I think sb_source fits better with the convention that the other fields
in the struct use. I say we stick with that.
--
Jeff Layton <jlayton@xxxxxxxxxx>