Re: [PATCH] arm64: qcom: qcs8300: Add ADSP and CDSP0 fastrpc nodes

[Konrad Dybcio]

On 12-Nov-24 08:49, Ling Xu wrote:
> Add ADSP and CDSP0 fastrpc nodes for QCS8300 platform.
> 
> Signed-off-by: Ling Xu <quic_lxu5@xxxxxxxxxxx>
> ---

[...]


> +				fastrpc {
> +					compatible = "qcom,fastrpc";
> +					qcom,glink-channels = "fastrpcglink-apps-dsp";
> +					label = "cdsp";
> +					#address-cells = <1>;
> +					#size-cells = <0>;
> +
> +					compute-cb@1 {
> +						compatible = "qcom,fastrpc-compute-cb";
> +						reg = <1>;
> +						iommus = <&apps_smmu 0x19c1 0x0440>,
> +							 <&apps_smmu 0x1dc1 0x0440>,
> +							 <&apps_smmu 0x1961 0x0400>,
> +							 <&apps_smmu 0x1d61 0x0400>,
> +							 <&apps_smmu 0x1981 0x0440>,
> +							 <&apps_smmu 0x1d81 0x0440>;

If you do SID & ~MASK, many of these come out to the same
value. Could you try to simplify the entries?

Konrad