Re: [PATCH v3 3/3] intel_idle: Provide enter_dead() handler for SRF

[Rafael J. Wysocki]

On Tue, Nov 12, 2024 at 12:18 PM Patryk Wlazlyn
<patryk.wlazlyn@xxxxxxxxxxxxxxx> wrote:
>
> > This series has said multiple times how the old algorithm is wrong.  But
> > it never actually _fixed_ the bad algorithm, only worked around it.
> >
> > Does mwait_play_dead() itself need to get fixed?
>
> I don't think so. The old algorithm gives fairly good heuristic for computing
> the mwait hint for the deepest cstate. Even though it's not guaranteed to work,
> it does work on most of the platforms that don't early return. I think we should
> leave it, but prefer idle_driver.

IOW, as a fallback mechanism, it is as good as it gets.

As the primary source of information though, not quite.

> >> Define the enter_dead() handler for SRF.
> >
> > This effectively gets the mwait hints from ______ instead of using the
> > calculation in mwait_play_dead().
>
> Ok.
>
> >> +static __cpuidle int intel_idle_enter_dead(struct cpuidle_device *dev,
> >> +                       int index)
> >> +{
> >> +    struct cpuidle_driver *drv = cpuidle_get_cpu_driver(dev);
> >> +    struct cpuidle_state *state = &drv->states[index];
> >> +    unsigned long eax = flg2MWAIT(state->flags);
> >> +
> >> +    /* Retruns only in case of an error. */
> >
> >        ^ returns?
>
> Yup. Will fix.
>
>