Re: [PATCH v8 net-next 3/4] ipv4/udp: Add 4-tuple hash for connected socket

[Paolo Abeni]

On 11/8/24 06:48, Philo Lu wrote:
[...]
> Signed-off-by: Philo Lu <lulie@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Cambda Zhu <cambda@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Fred Chen <fred.cc@xxxxxxxxxxxxxxx>
> Signed-off-by: Yubing Qiu <yubing.qiuyubing@xxxxxxxxxxxxxxx>

[...]
> @@ -2937,7 +3128,7 @@ struct proto udp_prot = {
>  	.owner			= THIS_MODULE,
>  	.close			= udp_lib_close,
>  	.pre_connect		= udp_pre_connect,
> -	.connect		= ip4_datagram_connect,
> +	.connect		= udp_connect,
>  	.disconnect		= udp_disconnect,
>  	.ioctl			= udp_ioctl,
>  	.init			= udp_init_sock,

2 minor notes, possibly not needing a repost:

- The SoB chain looks strange, do you mean co-developed-by actually?
- udplite is not touched. AFAICS should not be a problem - just the
feature will not be available for udplite. I'm wondering if syzbot could
prove me wrong about "not being a problem" (usually it's able to do that;)

/P