[PATCH v3] USB: core: remove dead code in do_proc_bulk()

From: Rex Nie
Date: Tue Nov 12 2024 - 12:09:40 EST


Since len1 is unsigned int, len1 < 0 always false. Remove it keep code
simple.

Signed-off-by: Rex Nie <rex.nie@xxxxxxxxxxxxxxx>
---
changelog:
v3:
- do not CC stable kernel (thanks greg k-h)
- Remove Fixes tag
- Link to v2:https://lore.kernel.org/all/2024111249-stifle-mundane-dbfc@gregkh/
v2:
- Add CC stable kernel tag (kernel test robot)
- Add Fixes tag
- Link to v1: https://lore.kernel.org/all/160ed4e4-0b8b-4424-9b3c-7aa159b8c735@xxxxxxxxxxxxxxxxxxx/
---
drivers/usb/core/devio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
index 3beb6a862e80..712e290bab04 100644
--- a/drivers/usb/core/devio.c
+++ b/drivers/usb/core/devio.c
@@ -1295,7 +1295,7 @@ static int do_proc_bulk(struct usb_dev_state *ps,
return ret;

len1 = bulk->len;
- if (len1 < 0 || len1 >= (INT_MAX - sizeof(struct urb)))
+ if (len1 >= (INT_MAX - sizeof(struct urb)))
return -EINVAL;

if (bulk->ep & USB_DIR_IN)
--
2.17.1