RE: [PATCH] hexagon: time: Remove redundant null check for resource

[Brian Cain]

> -----Original Message-----
> From: Hardevsinh Palaniya <hardevsinh.palaniya@xxxxxxxxxxxxxxxxx>
> Sent: Monday, November 11, 2024 8:24 AM
> To: akpm@xxxxxxxxxxxxxxxxxxxx; Brian Cain <bcain@xxxxxxxxxxx>
> Cc: Hardevsinh Palaniya <hardevsinh.palaniya@xxxxxxxxxxxxxxxxx>; Nathan
> Chancellor <nathan@xxxxxxxxxx>; linux-hexagon@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH] hexagon: time: Remove redundant null check for resource
> 
> 
> Null check for 'resource' before assignment is unnecessary because the
> variable 'resource' is initialized to NULL at the beginning of the function.
> 
> Signed-off-by: Hardevsinh Palaniya <hardevsinh.palaniya@xxxxxxxxxxxxxxxxx>
> ---

Acked-by: Brian Cain <bcain@xxxxxxxxxxx>

>  arch/hexagon/kernel/time.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/hexagon/kernel/time.c b/arch/hexagon/kernel/time.c
> index f0f207e2a694..6f851e1cd4ee 100644
> --- a/arch/hexagon/kernel/time.c
> +++ b/arch/hexagon/kernel/time.c
> @@ -170,8 +170,7 @@ static void __init time_init_deferred(void)
> 
>         ce_dev->cpumask = cpu_all_mask;
> 
> -       if (!resource)
> -               resource = rtos_timer_device.resource;
> +       resource = rtos_timer_device.resource;
> 
>         /*  ioremap here means this has to run later, after paging init  */
>         rtos_timer = ioremap(resource->start, resource_size(resource));
> --
> 2.43.0