Re: [PATCH] Remove unused function parameter in __smc_diag_dump

[Simon Horman]

On Tue, Nov 12, 2024 at 08:36:13AM +0100, Wenjia Zhang wrote:
> 
> 
> On 11.11.24 16:10, Manas wrote:
> > On 11.11.2024 15:11, Wenjia Zhang wrote:

...

> > Thank you Wenjia for reviewing this.
> > 
> > Should I make any changes to the commit message if we are going forward
> > with it
> > being as a cleanup patch? The commit message itself (barring the cover
> > letter)
> > should be enough, I reckon.
> > 
> I think it is ok as it is.

Yes, agreed.

The commit message should be truncated at first scissors ("---").
Which leaves us with a commit message only describing the removal
of an unused function parameter. Which, given the discussion in
this thread, is what we want.

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>

> 
> Thanks,
> Wenjia
>