Re: [PATCH v6 2/3] x86: probe memory block size advisement value during mm init
From: Dan Williams
Date: Tue Nov 12 2024 - 16:34:30 EST
Gregory Price wrote:
> Systems with hotplug may provide an advisement value on what the
> memblock size should be. Probe this value when the rest of the
> configuration values are considered.
>
> The new heuristic is as follows
>
> 1) set_memory_block_size_order value if already set (cmdline param)
> 2) minimum block size if memory is less than large block limit
> 3) if no hotplug advice: Max block size if system is bare-metal,
> otherwise use end of memory alignment.
> 4) if hotplug advice: lesser of advice and end of memory alignment.
This seems like documentation that also belongs in-line in the code.
Perhaps a follow-on to add this to memory_block_advised_max_size()?
For this one:
Acked-by: Dan Williams <dan.j.williams@xxxxxxxxx>