RE: [PATCH v3 net-next 2/5] net: enetc: add Tx checksum offload for i.MX95 ENETC

[Claudiu Manoil]

> -----Original Message-----
> From: Wei Fang <wei.fang@xxxxxxx>
> Sent: Tuesday, November 12, 2024 11:15 AM
[...]
> Subject: [PATCH v3 net-next 2/5] net: enetc: add Tx checksum offload for
> i.MX95 ENETC
> 
> In addition to supporting Rx checksum offload, i.MX95 ENETC also supports
> Tx checksum offload. The transmit checksum offload is implemented through
> the Tx BD. To support Tx checksum offload, software needs to fill some
> auxiliary information in Tx BD, such as IP version, IP header offset and
> size, whether L4 is UDP or TCP, etc.
> 
> Same as Rx checksum offload, Tx checksum offload capability isn't defined
> in register, so tx_csum bit is added to struct enetc_drvdata to indicate
> whether the device supports Tx checksum offload.
> 
> Signed-off-by: Wei Fang <wei.fang@xxxxxxx>
> ---
> v2: refine enetc_tx_csum_offload_check().
> v3:
> 1. refine enetc_tx_csum_offload_check() and enetc_skb_is_tcp() through
> skb->csum_offset instead of touching skb->data.
> 2. add enetc_skb_is_ipv6() helper function
> ---

Reviewed-by: Claudiu Manoil <claudiu.manoil@xxxxxxx>