Re: [PATCH v3 1/1] ufs: ufs_sb_private_info: remove unused s_{2,3}apb fields

From: Al Viro
Date: Tue Nov 12 2024 - 19:00:26 EST


On Tue, Nov 12, 2024 at 01:18:25PM +0100, Agathe Porte wrote:
> These two fields are populated and stored as a "frequently used value"
> in ufs_fill_super, but are not used afterwards in the driver.
>
> Moreover, one of the shifts triggers UBSAN: shift-out-of-bounds when
> apbshift is 12 because 12 * 3 = 36 and 1 << 36 does not fit in the 32
> bit integer used to store the value.
>
> Closes: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2087853
> Signed-off-by: Agathe Porte <agathe.porte@xxxxxxxxxxxxx>

Applied to viro/vfs.git#work.ufs