RE: [PATCH v15 3/4] hisi_acc_vfio_pci: register debugfs for hisilicon migration driver

[Shameerali Kolothum Thodi]

> -----Original Message-----
> From: Alex Williamson <alex.williamson@xxxxxxxxxx>
> Sent: Tuesday, November 12, 2024 9:51 PM
> To: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@xxxxxxxxxx>
> Cc: liulongfang <liulongfang@xxxxxxxxxx>; jgg@xxxxxxxxxx; Jonathan
> Cameron <jonathan.cameron@xxxxxxxxxx>; kvm@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; linuxarm@xxxxxxxxxxxxx
> Subject: Re: [PATCH v15 3/4] hisi_acc_vfio_pci: register debugfs for hisilicon
> migration driver
> 
> On Tue, 12 Nov 2024 08:40:03 +0000
> Shameerali Kolothum Thodi <shameerali.kolothum.thodi@xxxxxxxxxx>
> wrote:
> 
> > > -----Original Message-----
> > > From: liulongfang <liulongfang@xxxxxxxxxx>
> > > Sent: Tuesday, November 12, 2024 7:33 AM
> > > To: alex.williamson@xxxxxxxxxx; jgg@xxxxxxxxxx; Shameerali Kolothum
> > > Thodi <shameerali.kolothum.thodi@xxxxxxxxxx>; Jonathan Cameron
> > > <jonathan.cameron@xxxxxxxxxx>
> > > Cc: kvm@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> > > linuxarm@xxxxxxxxxxxxx; liulongfang <liulongfang@xxxxxxxxxx>
> > > Subject: [PATCH v15 3/4] hisi_acc_vfio_pci: register debugfs for hisilicon
> > > migration driver
> > >
> > >
> > > +static void hisi_acc_vfio_debug_init(struct hisi_acc_vf_core_device
> > > *hisi_acc_vdev)
> > > +{
> > > +	struct vfio_device *vdev = &hisi_acc_vdev->core_device.vdev;
> > > +	struct hisi_acc_vf_migration_file *migf = NULL;
> > > +	struct dentry *vfio_dev_migration = NULL;
> > > +	struct dentry *vfio_hisi_acc = NULL;
> >
> > Nit, I think we can get rid of these NULL initializations.
> 
> Yup, all three are unnecessary.
> 
> > If you have time, please consider respin (sorry, missed this in earlier
> reviews.)
> 
> If that's the only comment, I can fix that on commit if you want to add
> an ack/review conditional on that change.  Thanks,

Thanks Alex.

With the above nits addressed,

Reviewed-by: Shameer Kolothum <shameerali.kolothum.thodi@xxxxxxxxxx>

Shameer