Re: Re: [PATCH liburing] test: add test cases for hybrid iopoll

[hexue]

On 11/13/24 3:32, Pavel Begunkov wrote:
>On 11/11/24 12:36, hexue wrote:
>> Add a test file for hybrid iopoll to make sure it works safe.Testcass
>> include basic read/write tests, and run in normal iopoll mode and
>> passthrough mode respectively.
>>
>> Signed-off-by: hexue <xue01.he@xxxxxxxxxxx>

>If it's not covered already please add tests for failure cases.
>E.g. when SETUP_HYBRID_IOPOLL is set without SETUP_IOPOLL

I'll thinking about this part.

>> +	ring_flags |= IORING_SETUP_SQE128;
>> +	ring_flags |= IORING_SETUP_CQE32;
>> +	ring_flags |= IORING_SETUP_HYBRID_IOPOLL;
>> +
>> +	if (sqthread)
>> +		ring_flags |= IORING_SETUP_SQPOLL;

>Doesn't it also need IORING_SETUP_IOPOLL?

You're right, will fix this.

--
hexue