Re: [PATCH v9 8/9] thermal: Add PCIe cooling driver

[Lukas Wunner]

On Fri, Oct 18, 2024 at 05:47:54PM +0300, Ilpo Järvinen wrote:
>  static void pcie_bwnotif_remove(struct pcie_device *srv)
>  {
> +	struct pcie_bwctrl_data *data = srv->port->link_bwctrl;
> +
> +	if (data->cdev)
> +		pcie_cooling_device_unregister(data->cdev);
> +

Just noting a minor nit here in what is now commit 7206400cda87
on pci/bwctrl:  The NULL pointer check for data->cdev seems
redundant as pcie_cooling_device_unregister() just calls
thermal_cooling_device_unregister(), which in turn contains
this at the top:

	if (!cdev)
		return;

Thanks,

Lukas