Re: [PATCH] ext4: remove duplicate check for EXT4_FC_REPLAY

From: Zhang Yi
Date: Wed Nov 13 2024 - 04:01:56 EST


On 2024/11/13 12:41, Jinliang Zheng wrote:
> EXT4_FC_REPLAY will be checked in ext4_es_lookup_extent(). If it is
> set, ext4_es_lookup_extent() will return 0.
>
> Remove the repeated check for EXT4_FC_REPLAY in ext4_map_blocks()
> to simplify the code.
>
> Signed-off-by: Jinliang Zheng <alexjlzheng@xxxxxxxxxxx>

It makes sense to me, thanks for the cleanup.

Reviewed-by: Zhang Yi <yi.zhang@xxxxxxxxxx>

> ---
> fs/ext4/inode.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 89aade6f45f6..999f947c13d2 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -619,8 +619,7 @@ int ext4_map_blocks(handle_t *handle, struct inode *inode,
> return -EFSCORRUPTED;
>
> /* Lookup extent status tree firstly */
> - if (!(EXT4_SB(inode->i_sb)->s_mount_state & EXT4_FC_REPLAY) &&
> - ext4_es_lookup_extent(inode, map->m_lblk, NULL, &es)) {
> + if (ext4_es_lookup_extent(inode, map->m_lblk, NULL, &es)) {
> if (ext4_es_is_written(&es) || ext4_es_is_unwritten(&es)) {
> map->m_pblk = ext4_es_pblock(&es) +
> map->m_lblk - es.es_lblk;