Re: [PATCHv3 net-next] net: mellanox: use ethtool string helpers
From: Ido Schimmel
Date: Wed Nov 13 2024 - 04:39:28 EST
Thanks for the patch, but there are a few process issues.
On Tue, Nov 12, 2024 at 01:17:11PM -0800, Rosen Penev wrote:
> These are the preferred way to copy ethtool strings.
>
> Avoids incrementing pointers all over the place.
>
> Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
> Reviewed-by: Ido Schimmel <idosch@xxxxxxxxxx>
I only tagged the mlxsw change. The mlxbf change is new.
> ---
> v3: also convert memcpy.
> v2: rebase to make it apply.
> .../mellanox/mlxbf_gige/mlxbf_gige_ethtool.c | 5 +-
Please split the mlxbf change to a different patch and copy the relevant
maintainers:
davthompson@xxxxxxxxxx
asmaa@xxxxxxxxxx
Use "mlxbf_gige:" prefix for the mlxbf patch and "mlxsw:" for the mlxsw
patch. You can keep my tag on the latter.
> .../mellanox/mlxsw/spectrum_ethtool.c | 83 +++++++------------
> .../ethernet/mellanox/mlxsw/spectrum_ptp.c | 7 +-
> 3 files changed, 33 insertions(+), 62 deletions(-)