Re: [PATCH v4 3/3] media: qcom: camss: Add MSM8953 resources

[Bryan O'Donoghue]

On 13/11/2024 08:01, barnabas.czeman@xxxxxxxxxxxxxx wrote:
> > I see that you do reuse csiphy_res_8x16 for this platform support, in
> > this case let me ask you to double check/test that the "vdda" regulator
> > is actually a CSIPHY regulator, and if so, please move the registration
> > of the regulators to csiphy_res_8x16 as a preceding change.
> It is placed in CSID at downstream and this is the documentation of
> the downstream property:
> - qcom,mipi-csi-vdd-supply : should contain regulator to be used for
>      this csid core
> so it should be a csid regulator as i understand.
> It is also placed at CSIDs in msm8953-camera.dtsi

No, the regulator(s) supply voltage to the PHY.

Make sure you have:

commit 44fdbb9d1a3892db92b2c9cf5f46e32ca4095d92
Author: Vladimir Zapolskiy <vladimir.zapolskiy@xxxxxxxxxx>
Date:   Fri Sep 27 00:19:56 2024 +0300

    media: qcom: camss: add management of supply regulators to CSIPHY

and give the change a try.

---
bod