Re: [PATCH net-next v4 12/19] xdp: add generic xdp_build_skb_from_buff()

From: Toke Høiland-Jørgensen
Date: Wed Nov 13 2024 - 06:16:37 EST


Alexander Lobakin <aleksander.lobakin@xxxxxxxxx> writes:

> The code which builds an skb from an &xdp_buff keeps multiplying itself
> around the drivers with almost no changes. Let's try to stop that by
> adding a generic function.
> Unlike __xdp_build_skb_from_frame(), always allocate an skbuff head
> using napi_build_skb() and make use of the available xdp_rxq pointer to
> assign the Rx queue index. In case of PP-backed buffer, mark the skb to
> be recycled, as every PP user's been switched to recycle skbs.
>
> Signed-off-by: Alexander Lobakin <aleksander.lobakin@xxxxxxxxx>

Reviewed-by: Toke Høiland-Jørgensen <toke@xxxxxxxxxx>