Re: [PATCH net] samples: pktgen: correct dev to DEV

[Jesper Dangaard Brouer]

On 13/11/2024 11.06, Wei Fang wrote:
> > On 12/11/2024 04.03, Wei Fang wrote:
> > > In the pktgen_sample01_simple.sh script, the device variable is
> > > uppercase 'DEV' instead of lowercase 'dev'. Because of this typo, the
> > > script cannot enable UDP tx checksum.
> > >
> > > Fixes: 460a9aa23de6 ("samples: pktgen: add UDP tx checksum support")
> > > Signed-off-by: Wei Fang <wei.fang@xxxxxxx>
> > > ---
> > >    samples/pktgen/pktgen_sample01_simple.sh | 2 +-
> > >    1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/samples/pktgen/pktgen_sample01_simple.sh
> > > b/samples/pktgen/pktgen_sample01_simple.sh
> > > index cdb9f497f87d..66cb707479e6 100755
> > > --- a/samples/pktgen/pktgen_sample01_simple.sh
> > > +++ b/samples/pktgen/pktgen_sample01_simple.sh
> >
> > Why are you only fixing one script?
>
> Other scripts are correct, because they are all multi-threaded, "dev" is
> defined for each thread like below.
>
> dev=${DEV}@${thread}

Good point! - then this patch is enough :-)

Acked-by: Jesper Dangaard Brouer <hawk@xxxxxxxxxx>

Thanks for fixing this,
--Jesper