Re: [PATCH v4 6/8] x86/mce: Remove the unnecessary {}
From: Yazen Ghannam
Date: Wed Nov 13 2024 - 09:26:24 EST
On Wed, Nov 13, 2024 at 01:32:08PM +0000, Zhuo, Qiuxu wrote:
> Hi Yazen,
>
> > From: Yazen Ghannam <yazen.ghannam@xxxxxxx>
> > [...]
> >
> > Reviewed-by: Yazen Ghannam <yazen.ghannam@xxxxxxx>
>
> Thanks!
>
> > But please see note below.
> > [...]
> > > - case X86_VENDOR_AMD: {
> > > + case X86_VENDOR_AMD:
> > > mce_amd_feature_init(c);
> > > break;
> > > - }
> > >
> > > case X86_VENDOR_HYGON:
> > > mce_hygon_feature_init(c);
> > > --
> >
> > I think this could be a bit more substantive if you also combine the AMD and
> > HYGON cases. And remove mce_hygon_feature_init() which just calls
> > mce_amd_feature_init() anyway.
>
> How about a separate patch for this?
> If It's OK for you, I'll follow up on it after the current patch series has settled.
>
Sure thing. No problem.
Thanks,
Yazen