Re: [PATCH 1/2] sched/deadline: Restore dl_server bandwidth on non-destructive root domain changes

[Juri Lelli]

Hi Phil,

On 13/11/24 08:43, Phil Auld wrote:
> Hi Juri,
> 
> On Wed, Nov 13, 2024 at 12:57:22PM +0000 Juri Lelli wrote:
> > When root domain non-destructive changes (e.g., only modifying one of
> > the existing root domains while the rest is not touched) happen we still
> > need to clear DEADLINE bandwidth accounting so that it's then properly
> > restore taking into account DEADLINE tasks associated to each cpuset
> 
> "restored, taking ..."  ?

Yep.

> > (associated to each root domain). After the introduction of dl_servers,
> > we fail to restore such servers contribution after non-destructive
> > changes (as they are only considered on destructive changes when
> > runqueues are attached to the new domains).
> > 
> > Fix this by making sure we iterate over the dl_server attached to
> > domains that have not been destroyed and add them bandwidth contribution
> > back correctly.
> > 
> > Signed-off-by: Juri Lelli <juri.lelli@xxxxxxxxxx>
> 
> 
> Looks good to me. 
> 
> 
> Reviewed-by: Phil Auld <pauld@xxxxxxxxxx>

Thanks!
Juri