Re: [PATCH v2] arm64: Refactor conditional logic
From: Mark Brown
Date: Wed Nov 13 2024 - 10:54:26 EST
On Wed, Nov 13, 2024 at 10:48:18AM +0530, Hardevsinh Palaniya wrote:
> Unnecessarily checks ftr_ovr == tmp in an extra else if, which is not
> needed because that condition would already be true by default if the
> previous conditions are not satisfied.
Specifically the first one, if you revise it'd be good to be specific
about the logic here.
> Additionally, all branches set the variable str, making the subsequent
> "if (str)" check redundant
Reviewed-by: Mark Brown <broonie@xxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature