Re: [PATCH v6 07/11] printk: Constrain hardware-addressed console checks to name position

From: Petr Mladek
Date: Wed Nov 13 2024 - 11:20:59 EST


On Mon 2024-10-28 16:45:48, Chris Down wrote:
> Commit 7640f1a44eba ("printk: Add
> match_devname_and_update_preferred_console()") adds support for
> DEVNAME:n:n style console= registration. It determines whether or not
> this is a hardware-addressed console by looking at whether the console=
> string has a colon in it. However, this interferes with loglevel:n and
> potentially other future named options, which also make use of the
> character.
>
> In order to avoid this, only search positions before options.
>
> Signed-off-by: Chris Down <chris@xxxxxxxxxxxxxx>

Nice trick!

Reviewed-by: Petr Mladek <pmladek@xxxxxxxx>

Best Regards,
Petr