Re: [PATCH 2/2] sched/deadline: Correctly account for allocated bandwidth during hotplug

[Phil Auld]

On Wed, Nov 13, 2024 at 02:58:37PM +0000 Juri Lelli wrote:
> Hi Phil,
> 
> On 13/11/24 08:49, Phil Auld wrote:
> > 
> > Hi Juri,
> > 
> > On Wed, Nov 13, 2024 at 12:57:23PM +0000 Juri Lelli wrote:
> > > For hotplug operations, DEADLINE needs to check that there is still enough
> > > bandwidth left after removing the CPU that is going offline. We however
> > > fail to do so currently.
> > > 
> > > Restore the correct behavior by restructuring dl_bw_manage() a bit, so
> > > that overflow conditions (not enough bandwidth left) are properly
> > > checked. Also account for dl_server bandwidth, i.e. discount such
> > > bandwidht in the calculation since NORMAL tasks will be anyway moved
> > 
> > "bandwidth"  :)
> 
> Grrrr. :)
>

Yeah, those are just minor nits.   Maybe Peter can fix them on the
way by...


Cheers,
Phil

> > 
> > 
> > > away from the CPU as a result of the hotplug operation.
> > >
> > 
> > LGTM.
> > 
> > Reviewed-by: Phil Auld <pauld@xxxxxxxxxx>
> 
> Thanks!
> Juri
> 

--