Re: [PATCH v3 1/1] x86/fred: Clear WFE in missing-ENDBRANCH #CPs

From: Xin Li
Date: Wed Nov 13 2024 - 12:43:30 EST


On 11/13/2024 1:56 AM, Ingo Molnar wrote:

* Xin Li (Intel) <xin@xxxxxxxxx> wrote:

+/*
+ * By definition, all missing-ENDBRANCH #CPs are a result of WFE && !ENDBR.
+ *
+ * For the kernel IBT no ENDBR selftest where #CPs are deliberately triggerred,

s/triggerred
/triggered

+static void ibt_clear_fred_wfe(struct pt_regs *regs)
+{
+ /*
+ * No need to do any FRED checks.
+ *
+ * For IDT event delivery, the high-order 48 bits of CS are pushed
+ * as 0s into stack, and later IRET ignores these bits.

s/into stack
/into the stack


Thanks, fixing and sending v4 now.
Xin