Re: [PATCH v6 3/8] firmware_loader: Move module refcounts to allow unloading

From: Dionna Amalie Glaze
Date: Wed Nov 13 2024 - 13:40:42 EST


On Tue, Nov 12, 2024 at 6:40 PM Dan Williams <dan.j.williams@xxxxxxxxx> wrote:
>...
> However, I think the fix is simply to remove all module reference taking
> by the firmware_loader core. It is the consumer's responsibility to call
> firmware_upload_unregister() in its module removal path and that should
> flush any and all future usage of the passed in ops structure.

That would suggest the addition of the refcounting in v1 to fix a test
means the test_firmware is wrong?
https://lore.kernel.org/all/20220421212204.36052-5-russell.h.weight@xxxxxxxxx/

Adding Kees in case he knows better.

--
-Dionna Glaze, PhD, CISSP, CCSP (she/her)