Re: [PATCH 1/2] scripts/min-tool-version.sh: Raise minimum clang version to 19.1.0 for s390
From: Nathan Chancellor
Date: Wed Nov 13 2024 - 13:44:23 EST
On Wed, Nov 13, 2024 at 04:40:12PM +0100, Heiko Carstens wrote:
> Raise minimum clang version to 19.1.0 for s390 so that various inline
> assembly format flags can be used. The missing format flags were
> implemented with llvm-project commit 9c75a981554d ("[SystemZ] Implement A,
> O and R inline assembly format flags (#80685)").
>
> Signed-off-by: Heiko Carstens <hca@xxxxxxxxxxxxx>
Oof, this is quite new but now that kernel.org has LLVM binaries
available, I do not think this is an unreasonable ask, especially if it
makes your life easier with code maintenance.
Acked-by: Nathan Chancellor <nathan@xxxxxxxxxx>
One question: Is it worth dropping the mention about CC=clang for
clang-18 and older in Documentation/kbuild/llvm.rst? Maybe it is better
to leave it around for a bit just in case people read the newer
documentation while working on an older kernel?
> ---
> scripts/min-tool-version.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/min-tool-version.sh b/scripts/min-tool-version.sh
> index 91c91201212c..2dc674a74624 100755
> --- a/scripts/min-tool-version.sh
> +++ b/scripts/min-tool-version.sh
> @@ -25,7 +25,7 @@ gcc)
> ;;
> llvm)
> if [ "$SRCARCH" = s390 ]; then
> - echo 15.0.0
> + echo 19.1.0
> elif [ "$SRCARCH" = loongarch ]; then
> echo 18.0.0
> else
> --
> 2.45.2
>