Re: [PATCH 2/2] dt-bindings: iio: adc: adi,ad4695: change include path
From: David Lechner
Date: Wed Nov 13 2024 - 13:46:14 EST
On 11/13/24 12:18 PM, Rob Herring (Arm) wrote:
>
> On Wed, 13 Nov 2024 10:55:20 -0600, David Lechner wrote:
>> Change the include path for the adi,ad4695.h header since it has been
>> moved to the include/dt-bindings/iio/adc/ directory.
>>
>> Signed-off-by: David Lechner <dlechner@xxxxxxxxxxxx>
>> ---
>> Documentation/devicetree/bindings/iio/adc/adi,ad4695.yaml | 7 ++++---
>> 1 file changed, 4 insertions(+), 3 deletions(-)
>>
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/iio/adc/adi,ad4695.example.dts:19:18: fatal error: dt-bindings/iio/adc/adi,ad4695.h: No such file or directory
> 19 | #include <dt-bindings/iio/adc/adi,ad4695.h>
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Is this testing this patch without the other patch from this series?
I did run make `dt_binding_check DT_SCHEMA_FILES=adi,ad4695.yaml ...`
locally before sending the patch, so wasn't expecting an error here.
I know that normally we should be including the header change in the same
patch as the .yaml file, but in this case, I had to make an exception
because the same header is also included in a .c file. It seemed better
to not break compiling .c files rather than follow the rule strictly.