Re: [RFC 3/3] tick-sched: Replace jiffie readout with idle_entrytime
From: Joel Fernandes
Date: Wed Nov 13 2024 - 16:46:15 EST
On Tue, Nov 12, 2024 at 03:48:43PM +0100, Thomas Gleixner wrote:
> On Sun, Nov 10 2024 at 22:55, Joel Fernandes wrote:
> >
> > + /*
> > + * There is some time that passes between when clocksource starts and the
> > + * first time tick device is setup. Offset basejiff by that.
> > + */
> > + basejiff -= DIV_ROUND_DOWN_ULL(tick_first_period, TICK_NSEC);
>
> We clearly need yet another division here. Especially as that division
> results in the exactly same value every time.
Yeah I fixed it in my v2 but did not post it yet:
https://git.kernel.org/pub/scm/linux/kernel/git/jfern/linux.git/commit/?h=timers/tick-sched&id=60707e27418e3bca026be0bd9b1eacfe2a6ce72a
I will hold back on posting till we finish discussing on this RFC.
thanks,
- Joel