Re: [PATCH net-next 1/7] ynl: support attr-cnt-name attribute in legacy definitions

From: Stanislav Fomichev
Date: Wed Nov 13 2024 - 18:39:12 EST


On 11/13, Jakub Kicinski wrote:
> On Wed, 13 Nov 2024 10:10:17 -0800 Stanislav Fomichev wrote:
> > This is similar to existing attr-cnt-name in the attributes
> > to allow changing the name of the 'count' enum entry.
>
> why attr- ? we have similar attrs for cmd and we use cmd- as a prefix,
> so I'd just use enum-

Mostly because I don't have too much state on the spec side :-[ Did a
copy-paste from the attributes... Will switch to enum.

> I'd put it into genetlink-c level (you'll have to copy/paste into two
> specs), all the non-functional stuff related to C code gen is in the
> genetlink-c spec
>
> Please double check Documentation doesn't need extending

Will do, thanks for the pointers! The doc is definitely missing.