Re: [PATCH v2 05/25] x86/virt/tdx: Add SEAMCALL wrappers for TDX KeyID management

From: Edgecombe, Rick P
Date: Wed Nov 13 2024 - 19:02:14 EST


On Tue, 2024-11-12 at 12:09 -0800, Dave Hansen wrote:
> On 10/30/24 12:00, Rick Edgecombe wrote:
> > From: Isaku Yamahata <isaku.yamahata@xxxxxxxxx>
> >
> > Intel TDX protects guest VMs from malicious host and certain physical
> > attacks. Pre-TDX Intel hardware has support for a memory encryption
> > architecture called MK-TME, which repurposes several high bits of
> > physical address as "KeyID". TDX ends up with reserving a sub-range of
> > MK-TME KeyIDs as "TDX private KeyIDs".
>
> The changelog there was great.  It read my mind because I was wondering
> why some of the operations didn't get combined in helper functions which
> could be exported.
>
> Acked-by: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>

Thanks, I'll make the u64 removal changes to this one and leave the ack.