Re: [PATCH v2 05/35] x86/bugs: Restructure taa mitigation

[Pawan Gupta]

On Tue, Nov 05, 2024 at 03:54:25PM -0600, David Kaplan wrote:
> +static void __init taa_update_mitigation(void)
> +{
> +	if (!boot_cpu_has_bug(X86_BUG_TAA))
> +		return;
> +
> +	if (mitigate_any_verw())
> +		taa_mitigation = TAA_MITIGATION_VERW;

This isn't right, TAA_MITIGATION_UCODE_NEEDED can never get set
irrespective of microcode.

The UCODE_NEEDED checks in taa_select_mitigation() actually belongs here.