RE: [PATCH v2 02/22] HID: intel-thc-hid: Add basic THC driver skeleton

[Xu, Even]

> -----Original Message-----
> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Sent: Thursday, November 14, 2024 1:42 PM
> To: Xu, Even <even.xu@xxxxxxxxx>; jikos@xxxxxxxxxx; bentiss@xxxxxxxxxx;
> corbet@xxxxxxx; bagasdotme@xxxxxxxxx; Aaron, Ma
> <aaron.ma@xxxxxxxxxxxxx>
> Cc: linux-input@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-
> doc@xxxxxxxxxxxxxxx; Sun, Xinpeng <xinpeng.sun@xxxxxxxxx>; Zhang, Rui1
> <rui1.zhang@xxxxxxxxx>; Srinivas Pandruvada
> <srinivas.pandruvada@xxxxxxxxxxxxxxx>
> Subject: Re: [PATCH v2 02/22] HID: intel-thc-hid: Add basic THC driver skeleton
> 
> 
> 
> On 11/13/24 9:33 PM, Even Xu wrote:
> > diff --git a/drivers/hid/intel-thc-hid/Kconfig b/drivers/hid/intel-thc-hid/Kconfig
> > new file mode 100644
> > index 000000000000..e7e8201287f8
> > --- /dev/null
> > +++ b/drivers/hid/intel-thc-hid/Kconfig
> > @@ -0,0 +1,20 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +# Copyright (c) 2024, Intel Corporation.
> > +
> > +menu "Intel THC HID Support"
> > +	depends on X86_64 && PCI
> > +
> > +config INTEL_THC_HID
> > +	tristate "Intel Touch Host Controller"
> > +	select HID
> > +	help
> > +	  THC (Touch Host Controller) is the name of the IP block in PCH that
> > +	  interface with Touch Devices (ex: touchscreen, touchpad etc.). It
> 
> 	  interfaces                   (e.g.: touchscreen, touchpad, etc.). It

Will fix it in next version.

> 
> 
> > +	  is comprised of 3 key functional blocks: A natively half-duplex
> > +	  Quad I/O capable SPI master; A low latency I2C interface to support
> 
> 	                               a low

Will fix it.

> 
> > +	  HIDI2C compliant devices; A HW sequencer with RW DMA capability to
> 
> 	                          ; and a HW
> though I prefer to spell out              hardware      Read/Write

Agree, will fix it, thanks!

> 
> > +	  system memory.
> > +
> > +	  Say Y/M here if you want to support Intel THC. If unsure, say N.
> > +
> > +endmenu
> 
> --
> ~Randy

Thanks for the comments!

Best Regards,
Even Xu