Re: [PATCH v2 11/35] x86/bugs: Restructure spectre_v1 mitigation

From: Pawan Gupta
Date: Thu Nov 14 2024 - 01:57:25 EST


On Tue, Nov 05, 2024 at 03:54:31PM -0600, David Kaplan wrote:
> static void __init spectre_v1_select_mitigation(void)
> {
> - if (!boot_cpu_has_bug(X86_BUG_SPECTRE_V1) || cpu_mitigations_off()) {
> + if (!boot_cpu_has_bug(X86_BUG_SPECTRE_V1) || cpu_mitigations_off())
> spectre_v1_mitigation = SPECTRE_V1_MITIGATION_NONE;
> +}
> +
> +static void __init spectre_v1_apply_mitigation(void)
> +{
> + if (!boot_cpu_has_bug(X86_BUG_SPECTRE_V1) || cpu_mitigations_off())

We probably don't need to repeat this check, is this okay:

if (spectre_v1_mitigation == SPECTRE_V1_MITIGATION_NONE)
> return;
> - }
>
> if (spectre_v1_mitigation == SPECTRE_V1_MITIGATION_AUTO) {